Would you agree that Benjamin chose/put/whatever Frank in the position he is? And as far as we know he agrees as how his project is being handled?
I don’t see how you see that Frank is getting in the way of what you want? Just go on the VESC forum and open a suggestion there if there is a new cool feature you want
Make a post, explain how the braking you want works and how what is currently available differs from it, since its like Ackamaniac, post a link to his repo, if possible the exact location where it’s implemented
Quote Benjamin on this reverse mode pull request:
Thanks for the PR, and nice that you are getting involved with writing some VESC code! It looks good overall, just a few suggestions:
Instead of introducing config.max_erpm_for_dir_active, add one or more new ppm_control_type such as PPM_CTRL_TYPE_CURRENT_BRAKE_REV_HYST. It would otherwise be quite un-intuitive if PPM_CTRL_TYPE_CURRENT_NOREV_BRAKE can go reverse too. When you create new enums add them to the end, so that old configurations still are compatible as the enum is stored as an integer.
Does the adc_config struct really need the updates? The ADC app does not have them.
confgenerator has to be generated from VESC Tool. The signatures are generated from all variable names, so they must be correct for the configuration to be accepted. Updating confgenerator is actually quite easy using the parameter editors. Just keep in mind that VESC Tool has to be rebuilt with the new XML files before the new confgenerator can be generated. A tutorial for this is probably needed soon...
This is fucking weird. Just showed up on my youtube feed. I have no interest in software.
edit: just watched the video. mind blowing. I always thought github was a place for people who aren’t good enough to get a real coding job getting together to make pointless shit. lol
edit 2: girl narrates “there is a lot of business models on how people make money on open source. one of the models is, they don’t”.
Yeah, it doesn’t. Granted I haven’t tried the latest firmware, but I tried it when you said it was implemented and it didn’t work then and I’m done. I wont be using the VESC Tool again.