rideNEO GitHub, GPL contribution discussion (SERIOUS)

Hopefully that is what is happening on multiple fronts, I am done trying to influence and cajole and use logic to influence people that aren’t listening anyways.

2 Likes

If you tell me what is missing from the latest vesc_tool that you’re wanting, I can try my best to merge it into the latest for you. I have the week off. :grinning:

3 Likes

Specifically the ERPM switch option that requires a full stop before direction change, full brake the release then reverse. Buy it’s not needed for me specifically, I use Acks ESC Tool.

It would be great if available in the unity though.

1 Like

Would you agree that Benjamin chose/put/whatever Frank in the position he is? And as far as we know he agrees as how his project is being handled?

I don’t see how you see that Frank is getting in the way of what you want? Just go on the VESC forum and open a suggestion there if there is a new cool feature you want

4 Likes

I think @Deodand is working on that for Unity already if he havent give up on Unity since he no longer work for enertion

Mike, remember this? @DAddYE went through the pull request process and got it merged.

1 Like
  1. It’s not what I want, it’s what is good for esk8.

  2. I don’t see how.

I do remember that, then it disappeared. Also, didn’t work when it was there.

Again: Current Hyst reverse mode. Has been implemented already in June

Reverse options:

  • Hysteresis Reverse ( full stop, then brake again): Adjust speed in profiles
  • Smart Reverse (keep on pulling full brake): Adjust max speed in App section

Smart reverse is safer since it works when you panic.

Again, nope.

Will help you

Just go here

vesc-project.com/forum

Make a post, explain how the braking you want works and how what is currently available differs from it, since its like Ackamaniac, post a link to his repo, if possible the exact location where it’s implemented

Simple

3 Likes

Quote Benjamin on this reverse mode pull request:
Thanks for the PR, and nice that you are getting involved with writing some VESC code! It looks good overall, just a few suggestions:

Instead of introducing config.max_erpm_for_dir_active, add one or more new ppm_control_type such as PPM_CTRL_TYPE_CURRENT_BRAKE_REV_HYST. It would otherwise be quite un-intuitive if PPM_CTRL_TYPE_CURRENT_NOREV_BRAKE can go reverse too. When you create new enums add them to the end, so that old configurations still are compatible as the enum is stored as an integer.

Does the adc_config struct really need the updates? The ADC app does not have them.

confgenerator has to be generated from VESC Tool. The signatures are generated from all variable names, so they must be correct for the configuration to be accepted. Updating confgenerator is actually quite easy using the parameter editors. Just keep in mind that VESC Tool has to be rebuilt with the new XML files before the new confgenerator can be generated. A tutorial for this is probably needed soon...

Also, did you test the code with the updates?

It’s done though. In https://github.com/vedderb/bldc/pull/96 which is

Merged

vedderb merged 4 commits into vedderb:master from DAddYE:daddye

Hi @vedderb,

I’m planning to backport @Ackmaniac’s changes back upstream.

3 Likes

Well, then what the hell is Mike complaining?

2 Likes

Maybe it’s hard to find in the UI?

2 Likes

It doesn’t work on many VESC derivatives, but as I said don’t do it for me. Im good, I was just providing an example.

1 Like

This is fucking weird. Just showed up on my youtube feed. I have no interest in software.

edit: just watched the video. mind blowing. I always thought github was a place for people who aren’t good enough to get a real coding job getting together to make pointless shit. lol

edit 2: girl narrates “there is a lot of business models on how people make money on open source. one of the models is, they don’t”. :joy:

9 Likes

In a fork, what does this matter? People can choose to use the main project instead.

Not sure where my posts came off as hateful vs. concerned for the future interest of Frank, Ben and the community?

Lol, trackers, trackers everywhere…

1 Like

Github was bought by Microsoft.

1 Like